fix(cli): add oxlint-tsgolint dep to global cli - #248
Merged
wan9chi merged 1 commit intoOct 23, 2025
Conversation
wan9chi
marked this pull request as ready for review
October 23, 2025 02:10
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #246 by adding the missing oxlint-tsgolint dependency to the global CLI package, which enables the vite lint command to function properly.
- Added
oxlint-tsgolintas a dependency in the global package - Re-enabled the previously failing
vite lint -htest in CI workflow
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/global/package.json | Added oxlint-tsgolint dependency to support linting functionality |
| .github/workflows/ci.yml | Uncommented vite lint -h test now that the dependency is resolved |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fengmk2
approved these changes
Oct 23, 2025
Member
Author
Merge activity
|
wan9chi
deleted the
10-23-fix_cli_add_oxlint-tsgolint_dep_to_global_cli
branch
October 23, 2025 02:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #246 by adding
oxlint-tsgolintdependency.