Skip to content

build: fix reqwest build on Linux - #244

Merged
Brooooooklyn merged 1 commit into
mainfrom
10-22-build_fix_reqwest_build_on_linux
Oct 22, 2025
Merged

build: fix reqwest build on Linux#244
Brooooooklyn merged 1 commit into
mainfrom
10-22-build_fix_reqwest_build_on_linux

Conversation

@Brooooooklyn

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings October 22, 2025 07:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the reqwest build configuration for Linux systems by switching from native-tls to rustls-tls as the TLS backend. The change uses platform-specific dependency configurations to use native-tls on Windows and rustls-tls on non-Windows systems.

Key Changes:

  • Migrated reqwest dependency configuration from workspace-level to platform-specific declarations
  • Downgraded Zig version from 0.15.2 to 0.15.1 in the release workflow

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
crates/vite_package_manager/Cargo.toml Replaced unconditional reqwest dependency with platform-specific configurations (native-tls for Windows, rustls-tls for Linux)
Cargo.toml Removed default feature flags from workspace reqwest dependency, allowing platform-specific configurations to control features
.github/workflows/release.yml Downgraded Zig setup version from 0.15.2 to 0.15.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_package_manager/Cargo.toml Outdated
@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch from 110b8b0 to fb0f348 Compare October 22, 2025 07:39
Copilot AI review requested due to automatic review settings October 22, 2025 07:46
@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch from fb0f348 to c91c012 Compare October 22, 2025 07:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Cargo.toml Outdated
@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch from c91c012 to 1b81805 Compare October 22, 2025 07:53
@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch from 1b81805 to ed275f6 Compare October 22, 2025 08:19
Copilot AI review requested due to automatic review settings October 22, 2025 08:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch from ed275f6 to 5fc3f3e Compare October 22, 2025 08:39
Copilot AI review requested due to automatic review settings October 22, 2025 08:44
@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch from 5fc3f3e to bf3741c Compare October 22, 2025 08:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread crates/vite_error/Cargo.toml Outdated
@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch from bf3741c to 6139386 Compare October 22, 2025 08:59
Comment thread Cargo.toml Outdated
Copilot AI review requested due to automatic review settings October 22, 2025 09:47
@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch from 6139386 to 04c7b2d Compare October 22, 2025 09:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch 2 times, most recently from e834dae to eb4ac81 Compare October 22, 2025 09:58
Copilot AI review requested due to automatic review settings October 22, 2025 09:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch 2 times, most recently from 53c5b52 to 8e34107 Compare October 22, 2025 10:00
Copilot AI review requested due to automatic review settings October 22, 2025 10:12
@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch from 8e34107 to e0367de Compare October 22, 2025 10:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch 2 times, most recently from b4d362b to 11c6562 Compare October 22, 2025 10:26
Copilot AI review requested due to automatic review settings October 22, 2025 10:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch from 11c6562 to 1ba1c3d Compare October 22, 2025 10:34
Copilot AI review requested due to automatic review settings October 22, 2025 12:08
@Brooooooklyn
Brooooooklyn force-pushed the 10-22-build_fix_reqwest_build_on_linux branch from 1ba1c3d to 7798570 Compare October 22, 2025 12:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Brooooooklyn commented Oct 22, 2025

Copy link
Copy Markdown
Member Author

Merge activity

  • Oct 22, 12:18 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 22, 12:18 PM UTC: @Brooooooklyn merged this pull request with Graphite.

@Brooooooklyn
Brooooooklyn merged commit 8aaf814 into main Oct 22, 2025
14 checks passed
@Brooooooklyn
Brooooooklyn deleted the 10-22-build_fix_reqwest_build_on_linux branch October 22, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants