Add support for moving folders to system trash #113
Conversation
The 'trash' NPM package is added This dependency uses ESModule, requiring project refactoring Fixes voidcosmos#60
| export * from './cli.constants.js'; | ||
| export * from './main.constants.js'; | ||
| export * from './messages.constants.js'; | ||
| export * from './sort.result.js'; | ||
| export * from './spinner.constants.js'; | ||
| export * from './update.constants.js'; | ||
| export * from './recursive-rmdir-node-support.constants.js'; |
There was a problem hiding this comment.
Just curious why suffix file names with .js extension?
| export * from './console.service.js'; | ||
| export * from './files.service.js'; | ||
| export * from './https.service.js'; | ||
| export * from './linux-files.service.js'; | ||
| export * from './results.service.js'; | ||
| export * from './spinner.service.js'; | ||
| export * from './stream.service.js'; | ||
| export * from './update.service.js'; | ||
| export * from './windows-files.service.js'; |
|
Hi! Now that there should be no more ESM problems, could you reopen the PR with only the changes related to the feature? I will merge it as soon as possible. Thank! |
Adds a
--trashflag to the CLI to move anode_modulesto system trash rather than deleting directly.To use the
trashmodule, the project needs to be rewritten to use ESModulesThere is one test still outstanding that isn't running as I work out some compat issues, but wanted to create this now to solicit some feedback.
See #60