Skip to content

orkaudio: Fix leak in ConfigManager #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kingster wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

orkaudio: Fix leak in ConfigManager #112

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
78bc705
orkaudio: Fix leak in ConfigManager
kingster Jun 29, 2022
3bb7eea
Update ConfigManager.cpp
kingster Jun 29, 2022
5cee1ec
Update ConfigManager.cpp
kingster Jun 29, 2022
d8a6681
Merge branch 'master' into fix-leak-config-manager
kingster Jun 29, 2022
0cb9fd5
Update ConfigManager.cpp
kingster Jun 29, 2022
09cb867
Merge branch 'fix-leak-config-manager' of github.com:voiceip/oreka in…
kingster Jun 29, 2022
2bad620
Merge branch 'master' into fix-leak-config-manager
kingster Feb 6, 2025
bdccf9e
Merge branch 'master' into fix-leak-config-manager
kingster Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions orkbasecxx/ConfigManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ void ConfigManager::Initialize()
}
}

XMLPlatformUtils::Initialize();
XMLPlatformUtils::Initialize();
Copy link

@coderabbitai coderabbitai bot Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add corresponding XMLPlatformUtils::Terminate() call.

While XMLPlatformUtils::Initialize() is now correctly active, there's no matching Terminate() call. This could lead to resource leaks.

Consider adding cleanup in the destructor:

ConfigManager::~ConfigManager() {
    if (m_parser) {
        delete m_parser;
        m_parser = nullptr;
    }
    XMLPlatformUtils::Terminate();
}


// By default, the DOM document generated by the parser will be free() by the parser.
// If we ever need to free the parser and the document separately, we need to do this:
Expand All @@ -110,7 +110,7 @@ void ConfigManager::Initialize()
// doc->release();
// ...
// delete parser;
XercesDOMParser *m_parser = new XercesDOMParser;
m_parser = new XercesDOMParser;
XmlErrorHandler errhandler;
m_parser->setErrorHandler(&errhandler);
m_parser->parse(cfgFilename);
Expand Down
Loading