improve voice logic #483
improve voice logic #483
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
z4o4z
changed the base branch from
master
to
andrew/voice-widget-updates/DX-000
z4o4z
force-pushed
the
evgeny/improve-voice-logic/COR-4354
branch
from
29f3853 to
bb8a041
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| sourceOpen = true; | ||
| ref.outputSourceBuffer = outputMediaSource.addSourceBuffer('audio/mpeg'); | ||
|
|
||
| ref.outputSourceBuffer.abort |
There was a problem hiding this comment.
Looks like there's a missing semicolon and parentheses on this line. The correct syntax should be ref.outputSourceBuffer.abort();
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
this is a legacy implementation, can be removed
z4o4z
force-pushed
the
evgeny/improve-voice-logic/COR-4354
branch
from
bb8a041 to
99b8e45
Compare
z4o4z
merged commit fb57b93
into
andrew/voice-widget-updates/DX-000
Co-authored-by: Tyler Han <[email protected]>
Co-authored-by: Tyler Han <[email protected]>
Co-authored-by: Tyler Han <[email protected]>
Co-authored-by: Tyler Han <[email protected]>
Co-authored-by: Tyler Han <[email protected]>
Co-authored-by: Tyler Han <[email protected]>
Co-authored-by: Tyler Han <[email protected]>
Co-authored-by: Tyler Han <[email protected]>
Fixes or implements VF-XXX
Brief description. What is this change?
Implementation details. How do you make this change?
Setup information
Deployment Notes
Related PRs
Checklist