Skip to content
This repository has been archived by the owner on Feb 5, 2025. It is now read-only.

chore: clean some warnings from the console (COR-4258) #469

Closed
wants to merge 1 commit into from

Conversation

gillyb
Copy link
Contributor

@gillyb gillyb commented Dec 17, 2024

Fixes or implements VF-XXX

Brief description. What is this change?

Implementation details. How do you make this change?

Setup information

Deployment Notes

Related PRs

Checklist

  • Breaking changes have been communicated, including:
    • New required environment variables
    • Renaming of interfaces (API routes, request/response interface, etc)
  • New environment variables have been deployed
  • Appropriate tests have been written
    • Bug fixes are accompanied by an updated or new test
    • New features are accompanied by a new test

@gillyb gillyb requested a review from mikaalnaik December 17, 2024 15:11
Copy link

linear bot commented Dec 17, 2024

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-chat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 3:14pm

Copy link

graphite-app bot commented Dec 17, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@gillyb gillyb added the merge label Dec 17, 2024
Copy link
Contributor Author

gillyb commented Dec 17, 2024

Merge activity

  • Dec 17, 10:36 AM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 17, 10:36 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 17, 10:36 AM EST: CI is running for this PR on a draft PR: #470
  • Dec 17, 10:43 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #470.

gillyb added a commit that referenced this pull request Dec 17, 2024
<!-- You can erase any parts of this template not applicable to your Pull Request. -->

**Fixes or implements VF-XXX**

### Brief description. What is this change?

<!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion -->

### Implementation details. How do you make this change?

<!-- Explain the way/approach you follow to make this change more deeply in order to help your teammates to understand much easier this change -->

### Setup information

<!-- Notes regarding local environment. These should note any new configurations, new environment variables, etc. -->

### Deployment Notes

<!-- Notes regarding deployment the contained body of work. These should note any db migrations, etc. -->

### Related PRs

<!-- List related PRs against other branches -->

- https://github.com/voiceflow/XXXXXXXXX/pull/123

### Checklist

- [ ] Breaking changes have been communicated, including:
    - New required environment variables
    - Renaming of interfaces (API routes, request/response interface, etc)
- [ ] New environment variables have [been deployed](https://www.notion.so/voiceflow/Add-Environment-Variables-be1b0136479f45f1adece7995a7adbfb)
- [ ] Appropriate tests have been written
    - Bug fixes are accompanied by an updated or new test
    - New features are accompanied by a new test
@graphite-app graphite-app bot closed this Dec 17, 2024
@graphite-app graphite-app bot deleted the Gilly/clean-warnings/COR-4258 branch December 17, 2024 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants