refactor: simplify options into single url string

voiceflow · Dec 6, 2023 · 1692722 · 1692722
1 parent fcaf8d6
commit 1692722
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 13 deletions.
diff --git a/src/chargebee.interface.ts b/src/chargebee.interface.ts
@@ -1,11 +1,8 @@
 export interface ChargebeeModuleOptions {
   site: string;
   apiKey: string;
-  override: {
-    hostSuffix?: string;
-    apiPath?: string;
-    protocol?: "https" | "http";
-    port?: number;
+  override?: {
+    url?: string;
     timeout?: number;
   };
 }
diff --git a/src/chargebee.service.ts b/src/chargebee.service.ts
@@ -22,15 +22,19 @@ function configureChargebee(options: ChargebeeModuleOptions) {
   client.configure({
     site: options.site,
     api_key: options.apiKey,
-    ...(options.override?.hostSuffix
-      ? { hostSuffix: options.override.hostSuffix }
-      : {}),
-    ...(options.override?.apiPath ? { apiPath: options.override.apiPath } : {}),
-    ...(options.override?.protocol
-      ? { protocol: options.override.protocol }
-      : {}),
-    ...(options.override?.port ? { port: options.override.port } : {}),
+    ...(options.override?.url ? extractURLOptions(options.override.url) : {}),
     ...(options.override?.timeout ? { timeout: options.override.timeout } : {}),
   });
   return client;
 }
+
+function extractURLOptions(urlStr: string) {
+  const url = new URL(urlStr);
+
+  return {
+    hostSuffix: "." + url.host,
+    apiPath: url.pathname,
+    protocol: url.protocol.replace(":", ""),
+    port: url.port,
+  };
+}