fix(vector): normalize captured Chaikin helper - #204
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Unblock the v1.6.0 installed-wheel release gate after build run 31736493335 found the same Full Native source-compiler blocker on Linux, Windows, and macOS.
Change
np.zeros_like(..., dtype=np.float64)into the existing generic array IR.Validation
uv run pytest -q tests/test_indicator_program.py tests/test_full_vector_runtime.py(38 passed)uv run ruff check .uv run basedpyright --level error python/nfi_backtest_engine--level full: trade surface and state exact--level full: trade surface and state exactThe earlier failed build is retained as diagnostic evidence; the release workflow will only be dispatched again after this PR's Required CI and the resulting same-commit
mainCI pass.