Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the daemonset template for the log router helm chart. #437

Closed
wants to merge 1 commit into from

Conversation

RadOctocode
Copy link

@RadOctocode RadOctocode commented Feb 20, 2024

adding labels and additionalEnv from the values file to daemonset.yaml
I think I signed off the commit correctly but I still get the clabot prompt

@vmwclabot
Copy link
Member

@RadOctocode, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

  • Commit cf8b78a must be signed by RadOctocode

@vmwclabot
Copy link
Member

@RadOctocode, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

  • Commit fe38147 must be signed by RadOctocode

@vmwclabot
Copy link
Member

@RadOctocode, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

  • Commit 2506ecb must be signed by RadOctocode

@vmwclabot
Copy link
Member

@RadOctocode, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

  • Commit 1f7468f must be signed by RadOctocode

@RadOctocode
Copy link
Author

@javiercri I've signed off on my pr multiple times, but I'm still getting an issue with the vmwclabot. Am I missing somethingelse in my commit message? Is there a slack channel I can join to get feedback on my pr?

@RadOctocode
Copy link
Author

new pr with proper sign off here #439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants