This repository was archived by the owner on Mar 6, 2024. It is now read-only.
Fixing update_user to permit disabling a user #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When is_enabled is passed in as False, indicating that an account should be disabled, the conditional evaluates to False and does not execute the put_resource method to perform the requested action. Apologies... trying once again with the comparison to None using "is not" instead of "!="
rocknes
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @doug-baer)
doug-baer
commented
Jun 23, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When is_enabled is passed in as False, indicating that an account should be disabled, the conditional evaluates to False and does not execute the put_resource method to perform the requested action.
Apologies... trying once again with the comparison to None using "is not" instead of "!="
To help us process your pull request efficiently, please include:
(Required) Short description of changes in the PR topic line
(Required) Detailed description of changes include tests and
documentation. If the pull request contains multiple commits with
detailed messages, refer to those instead
(Optional) Names of reviewers using @ sign + name
This change is