-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
[ROCm][DSV4] Enable Tilelang MHC replacing torch/triton mhc #43679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9676182
use tilelang mhc on rocm
tjtanaa 5be8268
clean up mhc test
tjtanaa 122ad44
add tilelang to requirements.txt
tjtanaa 63d5159
add tilelang_hc_pre_norm_gemm
tjtanaa c966a7d
fix prefix commit; support fuse and unfused codepath
tjtanaa d2f3c6d
use tilelang mhc in mtp as well
tjtanaa 9111eee
clean up code
tjtanaa fbb43d7
clean up code
tjtanaa ed3db32
clean up code
tjtanaa d0534f7
bugfix functionality
tjtanaa 4610096
resolve merge conflict
tjtanaa 6656eb3
Merge remote-tracking branch 'origin/main' into tilelangmhc
tjtanaa dc01802
sync main
tjtanaa 77e91d6
Merge branch 'main' into tilelangmhc
tjtanaa 97c342a
add adaptation citation
tjtanaa 5bc61a4
remove unnecessary citation
tjtanaa 685bede
remove unnecessary citation
tjtanaa b1af57d
Merge branch 'main' into tilelangmhc
tjtanaa 8f40bc1
pin tilelang version rather than relax
tjtanaa 2c539fb
Merge branch 'tilelangmhc' of https://github.com/EmbeddedLLM/vllm int…
tjtanaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,3 +16,4 @@ wheel | |
| jinja2>=3.1.6 | ||
| amdsmi==7.0.2 | ||
| timm>=1.0.17 | ||
| tilelang>=0.1.10 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test and even nicer feature. i am wondering for CI purposes to avoid any regressions from future versions, should we pin the version? Maybe we can add it in
rocm.intoo. We can also do that in a follow-up PR. But let me know if you agree.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it in a follow up PR. Would like to land this PR and let @WoosukKwon continue with the restructuring of the mhc kernels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have pinned the version to exact version.