Skip to content

Conversation

nadathurv
Copy link
Contributor

@nadathurv nadathurv commented Sep 30, 2025

After this pr: #22524 the doc becomes outdated.

I have the option of listing relevant files like the __init__.py and compilation.py (is cache.py also relevant?) but I am not sure if that is the preference here, so I just updated it to the folder.

cc @ProExpertProg @hmellor

As per this PR: vllm-project#22524, config.py is split up into different files in this folder. 

Signed-off-by: nadathurv <[email protected]>
@nadathurv nadathurv changed the title updating torch.compile doc link [Docs] updating torch.compile doc link Sep 30, 2025
@mergify mergify bot added the documentation Improvements or additions to documentation label Sep 30, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates an outdated link in the torch.compile design document. The original link pointed to vllm/config.py, which is no longer accurate after recent refactoring. The change updates the link to point to the vllm/config directory, which contains all the relevant configuration files with compute_hash methods. This is a good approach as it is more maintainable than listing individual files. The change is correct and improves the documentation's accuracy.

@nadathurv nadathurv changed the title [Docs] updating torch.compile doc link [Doc] updating torch.compile doc link Sep 30, 2025
@nadathurv nadathurv closed this Sep 30, 2025
@nadathurv nadathurv deleted the patch-1 branch September 30, 2025 21:11
@nadathurv nadathurv restored the patch-1 branch September 30, 2025 21:15
@nadathurv nadathurv reopened this Sep 30, 2025
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That link won't work either. You've removed the gh-file shortcode

Signed-off-by: WorldExplored <[email protected]>
@nadathurv
Copy link
Contributor Author

nadathurv commented Sep 30, 2025

b951731 @hmellor was this commit correct?

@hmellor
Copy link
Member

hmellor commented Sep 30, 2025

Yes that should work, that will create a link to the directory on GitHub

Signed-off-by: nadathurv <[email protected]>
@hmellor
Copy link
Member

hmellor commented Sep 30, 2025

You can verify the link works at https://vllm--25989.org.readthedocs.build/en/25989/design/torch_compile.html (once it's finished building your most recent commit)

@nadathurv
Copy link
Contributor Author

nadathurv commented Sep 30, 2025

You can verify the link works at https://vllm--25989.org.readthedocs.build/en/25989/design/torch_compile.html (once it's finished building your most recent commit)

@hmellor works. thanks

@hmellor hmellor enabled auto-merge (squash) October 1, 2025 07:03
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 1, 2025
@hmellor hmellor merged commit 57b46d7 into vllm-project:main Oct 1, 2025
8 checks passed
@nadathurv nadathurv deleted the patch-1 branch October 1, 2025 11:22
pdasigi pushed a commit to pdasigi/vllm that referenced this pull request Oct 2, 2025
Signed-off-by: nadathurv <[email protected]>
Signed-off-by: WorldExplored <[email protected]>
Co-authored-by: Srreyansh Sethi <[email protected]>
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: nadathurv <[email protected]>
Signed-off-by: WorldExplored <[email protected]>
Co-authored-by: Srreyansh Sethi <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants