-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Doc] updating torch.compile doc link #25989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As per this PR: vllm-project#22524, config.py is split up into different files in this folder. Signed-off-by: nadathurv <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates an outdated link in the torch.compile
design document. The original link pointed to vllm/config.py
, which is no longer accurate after recent refactoring. The change updates the link to point to the vllm/config
directory, which contains all the relevant configuration files with compute_hash
methods. This is a good approach as it is more maintainable than listing individual files. The change is correct and improves the documentation's accuracy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That link won't work either. You've removed the gh-file
shortcode
Signed-off-by: WorldExplored <[email protected]>
76e989e
to
b8a972d
Compare
Yes that should work, that will create a link to the directory on GitHub |
Signed-off-by: nadathurv <[email protected]>
You can verify the link works at https://vllm--25989.org.readthedocs.build/en/25989/design/torch_compile.html (once it's finished building your most recent commit) |
@hmellor works. thanks |
Signed-off-by: nadathurv <[email protected]> Signed-off-by: WorldExplored <[email protected]> Co-authored-by: Srreyansh Sethi <[email protected]>
Signed-off-by: nadathurv <[email protected]> Signed-off-by: WorldExplored <[email protected]> Co-authored-by: Srreyansh Sethi <[email protected]> Signed-off-by: yewentao256 <[email protected]>
After this pr: #22524 the doc becomes outdated.
I have the option of listing relevant files like the
__init__.py
andcompilation.py
(iscache.py
also relevant?) but I am not sure if that is the preference here, so I just updated it to the folder.cc @ProExpertProg @hmellor