[BugFix] Fix eagle test broken by DeepSeek-V3.2 PR #25978
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Hill <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a test failure in test_load_model within tests/v1/spec_decode/test_eagle.py, which was caused by recent changes for DeepSeek-V3.2 support. The fix involves updating the mock for get_layers_from_vllm_config to account for new calls retrieving DeepseekV32IndexerCache layers. The change correctly aligns the test mock's behavior with the updated load_model implementation, and the explanatory comment is helpful for future maintenance. The fix is accurate and well-contained. I have no further suggestions.
heheda12345
approved these changes
Sep 30, 2025
|
@njhill CI still fails. |
|
:( sorry trying to do too many things at once, let me properly test this locally |
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Nick Hill <[email protected]>
|
The fixed have been included in #25982 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failure introduced in #25896.
https://buildkite.com/vllm/ci/builds/32916#0199998e-7340-408b-9866-a7b081862d2d