-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[DisaggEverything] Tokens in<>out /generate endpoint
#24261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This pull request has merge conflicts that must be resolved before it can be |
/generate endpoint/generate endpoint
|
EDIT: Moved to #22817 (comment) |
|
I see that If it's a different audience, it may be better suited to a different HTTP service scoped to a different audience and purpose. I had similar feedback about an earlier version of http metadata exchange for the Nixl connector, but the latest version seems to have moved it to its own http service: #22274 If it is desired to keep this on the existing OpenAI API, I think it'd be nice if we used namespacing to make it clear which APIs are our own custom ones vs. our implementation of APIs defined by OpenAI. One option would be something like |
We're still discussing with @smarterclayton the full spectrum of intended use cases.
I understand, would you be in favor of a separate entrypoint altogether? My motivation for keeping things inside the OAI one was to enable easy access to the other endpoints, which are not exclusive, at least in this early stage.
|
It's probably fine to keep within the same API. It doesn't seem harmful to expose (like maybe internal infrastructure metadata exchange would be).
Fair point. I just think it'd be nice to make it clear where we're copying OpenAI vs. defining our own completely independent APIs. It could be |
240f870 to
115b87f
Compare
|
@russellb Changed naming to the one you suggested. Let me know if there's something else I should change in this PR in your view, looking to move this forward |
|
I'm looking forward to this feature! Question: will this endpoint propagate |
|
This pull request has merge conflicts that must be resolved before it can be |
|
Documentation preview: https://vllm--24261.org.readthedocs.build/en/24261/ |
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
115b87f to
fdecd4f
Compare
Overview
First step in implementing the "Disaggregated Everything" proposal #22817.
This PR focuses on the following component:
In particular, it introduces:
GenerateRequest/Responseinterface. NOTE:SamplingParamscan now be validated and deserialized within a pydantic message (eg input-only). Check outPydanticMsgspecMixin./generatetokens-only endpoint/v1/chat/completionsfor the most part.--tokens-only"modality" for starting up the server, mostly intended to simplify ux./abort/request/endpoint, see below.Implementation Details
To get a "tokenizer-free" endpoint, one can already use
--skip_tokenizer_initand/ordetokenize: Falsesampling option, forcing the use of basicIncrementalDetokenizer.In order to make ux easier for a Disaggregated Everything setup, a
--tokens-onlyoption is added, which enforces the two flags above.This way the Detokenizer is optional, as intended in the initial design.
INFO 09-10 13:36:17 [arg_utils.py:1281] Skipping tokenizer initialization for tokens-only mode.Furthermore, it enables the
/abort_requestsendpoint./abort_requestsis a solution to the detection of stop strings, which is one of the main challenges to get a real "tokenizer-free" endpoint.Currently this is done in AsyncLLM output_handler_loop, followed by an IPC abort request back to the EngineCore, like so:
With this Disaggregated Everything, we task the "Coordinator" (to be implemented in a follow-up PR) with detokenization. Hence, the "generate" instance needs to act more as a "remote EngineCore". The workflow is the following:
How to test
or among other tests
Follow up PRs:
MultiModalFeatureSpecinput, will add once Renderer effort progresses