Skip to content

Conversation

@ckadner
Copy link
Collaborator

@ckadner ckadner commented Oct 17, 2025

Description

This PR is not meant to be merged into main. It adds tests and fixtures code on top of PR #533 from @maxdebayser

Fix the test test_find_model_by_config:

  • Add the e5-multilingual model config to test fixtures for the e5 multilingual model
  • Add more distinguishing attributes to known_model_configs.json

Related Issues

#533

maxdebayser and others added 3 commits October 16, 2025 12:48
@ckadner
Copy link
Collaborator Author

ckadner commented Oct 17, 2025

Ah, we need to add more parameters to the know models config file to distinguish between 'BAAI/bge-reranker-large' and 'intfloat/multilingual-e5-large'

 =========================== short test summary info ============================
FAILED tests/utils/test_model_config_validator.py::test_find_model_by_config - AssertionError: assert 2 == 1
 +  where 2 = len(['BAAI/bge-reranker-large', 'intfloat/multilingual-e5-large'])
==== 1 failed, 25 passed, 2 skipped, 552 deselected, 27 warnings in 31.44s =====
sys:1: DeprecationWarning: builtin type swigvarlink has no __module__ attribute
Error: Process completed with exit code 1.

@ckadner
Copy link
Collaborator Author

ckadner commented Oct 17, 2025

Passes now:

tests/utils/test_model_config_validator.py::test_find_model_by_config PASSED [ 71%]

Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner changed the title [WIP] Add model config to test fixtures for e5 multilingual model [WIP] Add model config to test fixtures for e5 multilingual model (for PR 533) Oct 17, 2025
@ckadner ckadner changed the title [WIP] Add model config to test fixtures for e5 multilingual model (for PR 533) [WIP] Add model config to test fixtures for e5 multilingual model (for PR #533) Oct 17, 2025
@vllm-project vllm-project deleted a comment from github-actions bot Oct 18, 2025
Signed-off-by: Christian Kadner <[email protected]>
@ckadner
Copy link
Collaborator Author

ckadner commented Oct 20, 2025

Merged into #533

@ckadner ckadner closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants