Skip to content

Conversation

prashantgupta24
Copy link
Collaborator

Description

Use defaults for all params for full_model marker. This enables us to use full_model marker which defaults to TP 4 and CB along with using sendnn and the full model

Related Issues

Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@waleedqk
Copy link
Collaborator

bot:test
TEST_FILE=tests/e2e/test_spyre_basic.py MARKERS="spyre"

1 similar comment
@waleedqk
Copy link
Collaborator

bot:test
TEST_FILE=tests/e2e/test_spyre_basic.py MARKERS="spyre"

@joerunde
Copy link
Collaborator

@waleedqk I think we'd need to run the full_model mark in order to test this change

@waleedqk
Copy link
Collaborator

@joerunde I was using an active PR to test the build and test process
not specifically testing the branch - but will change the marker so can check both

@waleedqk
Copy link
Collaborator

bot:test
TEST_FILE=tests/e2e/test_spyre_basic.py MARKERS="full_model"

3 similar comments
@waleedqk
Copy link
Collaborator

bot:test
TEST_FILE=tests/e2e/test_spyre_basic.py MARKERS="full_model"

@waleedqk
Copy link
Collaborator

bot:test
TEST_FILE=tests/e2e/test_spyre_basic.py MARKERS="full_model"

@waleedqk
Copy link
Collaborator

bot:test
TEST_FILE=tests/e2e/test_spyre_basic.py MARKERS="full_model"

@waleedqk
Copy link
Collaborator

bot:test
TEST_FILE=tests/e2e/test_spyre_basic.py MARKERS="full_model"

@prashantgupta24 prashantgupta24 marked this pull request as draft October 15, 2025 17:47
@prashantgupta24
Copy link
Collaborator Author

Converting to a draft because we want to reimagine this with the vdpp marker that we are thinking about right now

@waleedqk
Copy link
Collaborator

bot:test
TEST_FILE=tests/e2e/test_spyre_basic.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants