Skip to content

Support DP for unified attention #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 22, 2025
Merged

Support DP for unified attention #242

merged 11 commits into from
Oct 22, 2025

Conversation

@wuxun-zhang
Copy link
Contributor

@wuxun-zhang wuxun-zhang commented Sep 24, 2025 •
edited
Loading

Depends on #226.
See last commit added for this PR.

@wuxun-zhang
Copy link
Contributor Author

@madamczyk-intel @adobrzyn Hi, can you please help review changes of unified attention part (813e945)?

@wuxun-zhang
Support DP for unified atten
4e62621 
Signed-off-by: Wuxun Zhang <[email protected]>
@wuxun-zhang wuxun-zhang force-pushed the wuxun/support-dp-unified-attn branch from 602f874 to 4e62621 Compare September 25, 2025 01:59
@wuxun-zhang
Copy link
Contributor Author

Now dependency PR was merged. Rebased aganst main branch.

@wuxun-zhang
Copy link
Contributor Author

@xuechendi Do you think we need add test for DP + unified attn enabled?

@xuechendi
Copy link
Collaborator

@xuechendi Do you think we need add test for DP + unified attn enabled?

I think unified attention is not Final, @madamczyk-intel , what do you think?

adobrzyn
adobrzyn approved these changes Sep 30, 2025
View reviewed changes
Copy link
Collaborator

@adobrzyn adobrzyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

✅ CI Passed

All checks passed successfully against the following vllm commit:
c242c98031b87d00999e07dbb4aa9b2a70798c6c

@github-actions
Copy link

✅ CI Passed

All checks passed successfully against the following vllm commit:
314285d4f2134111345b4c4cbb583a925db9a91d

@github-actions
Copy link

✅ CI Passed

All checks passed successfully against the following vllm commit:
12e21701e7711b64963857386edf278dcf1b12b9

yafshar
yafshar reviewed Oct 20, 2025
View reviewed changes
@github-actions
Copy link

✅ CI Passed

All checks passed successfully against the following vllm commit:
bfe0b4bd2a4f8c7d2bcc0608556a91bdf5dd4566

@github-actions
Copy link

✅ CI Passed

All checks passed successfully against the following vllm commit:
c9461e05a4ed3557cfbf4b15ded1e26761cc39ca

@xuechendi xuechendi merged commit 54fd7c2 into vllm-project:main Oct 22, 2025
36 checks passed
hlahkar pushed a commit to hlahkar/vllm-gaudi that referenced this pull request Oct 24, 2025
@wuxun-zhang @xuechendi
@adobrzyn @hlahkar
Support DP for unified attention (vllm-project#242)
b4aed97 
~Depends on vllm-project#226
See last commit added for this PR.

---------

Signed-off-by: Wuxun Zhang <[email protected]>
Co-authored-by: Chendi.Xue <[email protected]>
Co-authored-by: Agata Dobrzyniewicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adobrzyn adobrzyn adobrzyn approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@xuechendi xuechendi Awaiting requested review from xuechendi xuechendi is a code owner

@mswiniarsk mswiniarsk Awaiting requested review from mswiniarsk mswiniarsk is a code owner

@mgawarkiewicz-intel mgawarkiewicz-intel Awaiting requested review from mgawarkiewicz-intel mgawarkiewicz-intel is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski is a code owner

@iboiko-habana iboiko-habana Awaiting requested review from iboiko-habana iboiko-habana is a code owner

+1 more reviewer

@yafshar yafshar yafshar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wuxun-zhang @xuechendi @yafshar @adobrzyn