Skip to content

Add tests for custom operator implementation correctness #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add tests for custom operator implementation correctness #222

wants to merge 4 commits into from

Conversation

Kacper-Pietkun
Copy link
Contributor

@Kacper-Pietkun Kacper-Pietkun commented Sep 22, 2025 •
edited
Loading

I added tests for custom ops defined in vllm_gaudi/ops:

  • For the tests of ops that are not using cuda kernels - native ops and hpu ops are triggered for the same input and their outputs are compared
  • For others tests that are using cuda kernels (so cannot be called with vllm-gaudi plugin) I created separate directory to store some predefined small tensors - weights, inputs and outputs (they are too big to hardcode them in tests). Such tests run hpu ops with loaded inputs and weights and compare their outputs with the loaded outputs.

@Kacper-Pietkun
Add tests for some ops
9be02c8 
Signed-off-by: Kacper Pietkun <[email protected]>
@Kacper-Pietkun
add more tests (fp8)
961e87a 
Signed-off-by: Kacper Pietkun <[email protected]>
@Kacper-Pietkun Kacper-Pietkun force-pushed the dev/kpietkun/tests_custom_op_correctness branch from 3786e06 to 961e87a Compare October 3, 2025 09:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@Kacper-Pietkun
remove unnecessary files
d4f1c7f 
Signed-off-by: Kacper Pietkun <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@Kacper-Pietkun
fix tests
ef42dd8 
Signed-off-by: Kacper Pietkun <[email protected]>
@Kacper-Pietkun Kacper-Pietkun force-pushed the dev/kpietkun/tests_custom_op_correctness branch from 500c41d to ef42dd8 Compare October 3, 2025 12:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel will be requested when the pull request is marked ready for review kzawora-intel is a code owner

@xuechendi xuechendi Awaiting requested review from xuechendi xuechendi will be requested when the pull request is marked ready for review xuechendi is a code owner

@mswiniarsk mswiniarsk Awaiting requested review from mswiniarsk mswiniarsk will be requested when the pull request is marked ready for review mswiniarsk is a code owner

@adobrzyn adobrzyn Awaiting requested review from adobrzyn adobrzyn will be requested when the pull request is marked ready for review adobrzyn is a code owner

@mgawarkiewicz-intel mgawarkiewicz-intel Awaiting requested review from mgawarkiewicz-intel mgawarkiewicz-intel will be requested when the pull request is marked ready for review mgawarkiewicz-intel is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe will be requested when the pull request is marked ready for review vivekgoe is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel will be requested when the pull request is marked ready for review afierka-intel is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski will be requested when the pull request is marked ready for review michalkuligowski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Kacper-Pietkun