-
Notifications
You must be signed in to change notification settings - Fork 655
[Misc] Upgrade vllm commit to 12_05 #4733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates a vLLM commit hash in the versioning_policy.md documentation file. The main issue found during the review is that this change causes the documentation translations to become outdated. Specifically, the Chinese translation file is now missing the updated compatibility information, which could mislead users. I have added a comment recommending that the translation files be updated to maintain consistency.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ec300b0 to
dbab592
Compare
Signed-off-by: wangli <[email protected]>
|
rebase to main please |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
What this PR does / why we need it?
Pooling models now support chunked prefill
Does this PR introduce any user-facing change?
How was this patch tested?