Skip to content

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Dec 5, 2025

What this PR does / why we need it?

  1. fix [Model][6/N] Improve all pooling task | Support chunked prefill with ALL pooling vllm#27145
    Pooling models now support chunked prefill

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a vLLM commit hash in the versioning_policy.md documentation file. The main issue found during the review is that this change causes the documentation translations to become outdated. Specifically, the Chinese translation file is now missing the updated compatibility information, which could mislead users. I have added a comment recommending that the translation files be updated to maintain consistency.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions github-actions bot added documentation Improvements or additions to documentation merge-conflicts labels Dec 5, 2025
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Potabk Potabk force-pushed the upgrade_12_05 branch 2 times, most recently from ec300b0 to dbab592 Compare December 5, 2025 07:44
@Potabk Potabk added ready read for review ready-for-test start test by label for PR labels Dec 5, 2025
@Potabk Potabk added ready read for review ready-for-test start test by label for PR and removed ready read for review ready-for-test start test by label for PR labels Dec 5, 2025
@wangxiyuan
Copy link
Collaborator

rebase to main please

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation merge-conflicts ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants