Skip to content

[CI] Refect accuracy test #4726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zhangxinyuehfad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CI] Refect accuracy test #4726

zhangxinyuehfad wants to merge 1 commit into from
+74 −21

Conversation

@zhangxinyuehfad
Copy link
Contributor

@zhangxinyuehfad zhangxinyuehfad commented Dec 4, 2025 •
edited by github-actions bot
Loading

What this PR does / why we need it?

  1. add accuracy test to full test per pr
  2. Model groups of different sizes use different runners
  3. qwen2-audio & llava-1.5-7b-hf & gemma-3-4b-it accuracy test by eager mode

plz merge it after accuracy test ok

Does this PR introduce any user-facing change?

How was this patch tested?

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 4, 2025

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Yikun
Yikun reviewed Dec 5, 2025
View reviewed changes
Copy link
Member

@Yikun Yikun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. This some thing we need to move forward with quickly, please done as soon as possible. also cc @menogrey

.github/workflows/vllm_ascend_test_pr_light.yaml Outdated
type: light

e2e-accuracy:
needs: [lint, changes]
Copy link
Member

@Yikun Yikun Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this. one thought is should accuracy trigger for all jobs? @wangxiyuan or just in full test?

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@zhangxinyuehfad zhangxinyuehfad force-pushed the zxy_refect_accuracy branch 2 times, most recently from cef47ad to 20a620a Compare December 8, 2025 02:50
@zhangxinyuehfad zhangxinyuehfad changed the title [CI] Refect accuarcy test [CI] Refect accuracy test Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@zhangxinyuehfad zhangxinyuehfad force-pushed the zxy_refect_accuracy branch 3 times, most recently from 778b479 to 822491a Compare December 10, 2025 02:45
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@zhangxinyuehfad zhangxinyuehfad force-pushed the zxy_refect_accuracy branch 2 times, most recently from fd51dda to bb38331 Compare December 11, 2025 06:45
@vllm-ascend-ci vllm-ascend-ci added ready read for review ready-for-test start test by label for PR labels Dec 11, 2025
@github-actions
Copy link

github-actions bot commented Dec 14, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yikun Yikun Yikun left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

merge-conflicts module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangxinyuehfad @Yikun @vllm-ascend-ci