Skip to content

Conversation

shanjiaz
Copy link
Collaborator

@shanjiaz shanjiaz commented Oct 9, 2025

Instead of assuming 1 hidden layer, pull num_hidden_layers from checkpoint config.

Signed-off-by: shanjiaz <[email protected]>
Copy link

github-actions bot commented Oct 9, 2025

📦 Build Artifacts Available
The build artifacts (`.whl` and `.tar.gz`) have been successfully generated and are available for download: https://github.com/vllm-project/speculators/actions/runs/18501864072/artifacts/4266910537.
They will be retained for up to 30 days.
Commit: 93f76b6

Signed-off-by: shanjiaz <[email protected]>
@shanjiaz shanjiaz marked this pull request as ready for review October 9, 2025 14:04
Signed-off-by: shanjiaz <[email protected]>
fynnsu
fynnsu previously approved these changes Oct 9, 2025
rahul-tuli
rahul-tuli previously approved these changes Oct 13, 2025
Copy link
Collaborator

@rahul-tuli rahul-tuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending a test converting an actual 2 layer checkpoint! Great work on this!

Signed-off-by: shanjiaz <[email protected]>
Signed-off-by: shanjiaz <[email protected]>
Signed-off-by: shanjiaz <[email protected]>
@shanjiaz shanjiaz dismissed stale reviews from rahul-tuli and fynnsu via 93f76b6 October 14, 2025 15:33
@shanjiaz shanjiaz requested review from fynnsu and rahul-tuli October 14, 2025 15:43
Copy link
Collaborator

@rahul-tuli rahul-tuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shanjiaz shanjiaz merged commit 6b7b43d into main Oct 14, 2025
12 checks passed
@shanjiaz shanjiaz deleted the feat-multi-layers branch October 14, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants