Add runner selection dropdown for manual Buildkite triggers#744
Conversation
Add build summary banner and meta-data based runner selection to pipeline.yml. Works with Buildkite UI input step to allow manual runner override (H100duo default, L4solo alternative). Follows the same pattern used in the Speculators repo. Signed-off-by: Deepak Kumar <deepakku@redhat.com>
Summary by CodeRabbit
WalkthroughThe Buildkite ChangesBuildkite Pipeline Runner Selection
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.buildkite/pipeline.yml:
- Around line 5-16: The RUNNER variable is user-controlled metadata retrieved at
line 5 and used directly in the pipeline upload path at line 16 without
validation, which could allow uploading unintended or missing YAML files that
break the CI flow. Add validation after the RUNNER variable assignment to ensure
it only contains allowed values from the allowlist (L4solo or H100duo), and if
validation fails, exit with an error message. Additionally, wrap the RUNNER
variable in quotes in the buildkite-agent pipeline upload command to protect
against path injection and other shell expansion issues.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e8158aea-dd44-47ce-ac06-24aaffd69d1b
📒 Files selected for processing (1)
.buildkite/pipeline.yml
dsikka
left a comment
There was a problem hiding this comment.
why is this one l4solo and the speculators one is l4solo?
Both the L4 gpu are same. |
Summary
Reason
H100 nodes on WDC cluster have NVIDIA driver failures.
What changed
.buildkite/pipeline.yml— added build summary banner, meta-data based runner selection, changed default runner from H100duo to L4soloUsage
Revert
Once the H100 cluster issue is resolved, revert this change by switching the default back to H100duo in
.buildkite/pipeline.yml.Reference