Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline generator #36

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Pipeline generator #36

wants to merge 22 commits into from

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Sep 25, 2024 •
edited
Loading

  • Add PipelineGenerator class and its methods
  • Add TestStep and BuildkiteStep into step module
  • Convert all plugin default values into constant to test it easier
  • Add generate_pipeline into ci_aws_bootstrap to use the new pipeline generator

khluu added 17 commits September 25, 2024 08:34
@khluu
p
c866ce2 
Signed-off-by: kevin <[email protected]>
@khluu
p
c8c1cde 
Signed-off-by: kevin <[email protected]>
@khluu
p
4f3aa69 
Signed-off-by: kevin <[email protected]>
@khluu
p
2f50078 
Signed-off-by: kevin <[email protected]>
@khluu
p
d3bf36e 
Signed-off-by: kevin <[email protected]>
@khluu
p
021b042 
Signed-off-by: kevin <[email protected]>
@khluu
p
8dfa7d7 
Signed-off-by: kevin <[email protected]>
@khluu
p
cc23358 
Signed-off-by: kevin <[email protected]>
@khluu
p
cf79847 
Signed-off-by: kevin <[email protected]>
@khluu
p
aeb85b6 
Signed-off-by: kevin <[email protected]>
@khluu
p
e05d0eb 
Signed-off-by: kevin <[email protected]>
@khluu
p
1412ca5 
Signed-off-by: kevin <[email protected]>
@khluu
p
51e6fca 
Signed-off-by: kevin <[email protected]>
@khluu
p
6272ba4 
Signed-off-by: kevin <[email protected]>
@khluu
p
081017a 
Signed-off-by: kevin <[email protected]>
@khluu
p
a1e3081 
Signed-off-by: kevin <[email protected]>
@khluu
format
be93571 
Signed-off-by: kevin <[email protected]>
@khluu khluu requested a review from aslonnie September 26, 2024 10:20
@khluu
Copy link
Collaborator Author

khluu commented Sep 26, 2024 •
edited
Loading

test build here: https://buildkite.com/vllm/ci-aws/builds/9160
Failing tests are also failing on main

@khluu
fix test
4bb3790 
Signed-off-by: kevin <[email protected]>
aslonnie
aslonnie reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

talked offline. let's try split this into smaller PR's with clearer modularization / layers.

@khluu
p
7dab021 
Signed-off-by: kevin <[email protected]>
@khluu
p
88e406b 
Signed-off-by: kevin <[email protected]>
@khluu
merge
d597bb4 
Signed-off-by: kevin <[email protected]>
@khluu khluu mentioned this pull request Oct 8, 2024
Closed
@khluu
p
826ae4a 
Signed-off-by: kevin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslonnie aslonnie aslonnie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khluu @aslonnie