migrated to vlingo/actors 0.7.4, except generic parser

CODE_OF_CONDUCT.md

@@ -0,0 +1,46 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at [email protected]. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/4/

CONTRIBUTING.md

@@ -0,0 +1,37 @@
+## How to contribute to the vlingo/common
+
+#### **Did you find a bug?**
+
+* Make sure the bug was not already reported here: [Issues](https://github.com/vlingo-net/vlingo-net-actors/issues).
+
+* If nonexisting, open a new issue for the problem: [Open New Issue](https://github.com/vlingo-net/vlingo-net-actors/issues/new). Always provide a **title and clear description**, as much relevant information as possible, and a **code sample** or an **executable test case** demonstrating the expected behavior that is not occurring.
+
+#### **Patches and bug fixes**
+
+* Open a new GitHub pull request with the patch.
+
+* Ensure the PR description clearly describes the problem and solution. Include the relevant issue number if applicable.
+
+* It would be really nice if your followed the basic code format used prevelently.
+
+#### **Please don't reformat existing code**
+
+* Just because you don't like a given code style doesn't mean you have the authority to change it. Cosmeic changes add zero to little value.
+
+#### **New features and enhancements**
+
+* Email your post your suggestion and provide an example implementation.
+
+* After agreement open a PR or issue.
+
+#### **Direct questions to...**
+
+* Vaughn Vernon: vaughn at kalele dot io
+
+#### **Contribute to documentation**
+
+* Vaughn Vernon: vaughn at kalele dot io
+
+Thanks for your kind assistance! :smile:
+
+Vaughn Vernon and the Vlingo .NET team

src/Vlingo.Actors.Tests/ActorEnvironmentTest.cs

@@ -5,7 +5,6 @@
 // was not distributed with this file, You can obtain
 // one at https://mozilla.org/MPL/2.0/.
 
-using System;
 using Vlingo.Actors.TestKit;
 using Xunit;
 

src/Vlingo.Actors.Tests/ActorFactoryTest.cs

@@ -5,14 +5,15 @@
 // was not distributed with this file, You can obtain
 // one at https://mozilla.org/MPL/2.0/.
 
+using System;
 using System.Threading;
 using Vlingo.Actors.Plugin.Mailbox.TestKit;
 using Xunit;
 
 namespace Vlingo.Actors.Tests
 {
     public class ActorFactoryTest : ActorsTest
-    { 
+    {
         [Fact]
         public void TestActorForWithNoParametersAndDefaults()
         {
@@ -88,7 +89,28 @@ public void TestActorForWithParameters()
             Assert.Equal(mailbox, actor.LifeCycle.Environment.Mailbox);
         }
 
-        public sealed class ParentInterfaceActor : Actor, IParentInterface
+        [Fact]
+        public void TestConstructorFailure()
+        {
+            World.ActorFor<IParentInterface>(Definition.Has<ParentInterfaceActor>(Definition.NoParameters));
+            var address = World.AddressFactory.UniqueWith("test-actor-ctor-failure");
+            var definition = Definition.Has<FailureActor>(
+                Definition.Parameters("test-ctor-failure", -100), 
+                ParentInterfaceActor.Instance.Value, 
+                address.Name);
+            var mailbox = new TestMailbox();
+
+            Assert.Throws<ArgumentException>(() => ActorFactory.ActorFor(
+                World.Stage,
+                definition.Parent,
+                definition,
+                address,
+                mailbox,
+                null,
+                World.DefaultLogger));
+        }
+
+        private class ParentInterfaceActor : Actor, IParentInterface
         {
             public static ThreadLocal<ParentInterfaceActor> Instance { get; } = new ThreadLocal<ParentInterfaceActor>();
 
@@ -100,11 +122,19 @@ public ParentInterfaceActor()
 
         public interface ITestInterface { }
 
-        internal sealed class TestInterfaceActor : Actor, ITestInterface { }
+        private class TestInterfaceActor : Actor, ITestInterface { }
 
-        internal sealed class TestInterfaceWithParamsActor : Actor, ITestInterface
+        private class TestInterfaceWithParamsActor : Actor, ITestInterface
         {
             public TestInterfaceWithParamsActor(string text, int val) { }
         }
+
+        private class FailureActor : Actor, ITestInterface
+        {
+            public FailureActor(string text, int val)
+            {
+                throw new InvalidOperationException("Failed in ctor with: " + text + " and: " + val);
+            }
+        }
     }
 }

src/Vlingo.Actors.Tests/ActorStopTest.cs

@@ -6,8 +6,8 @@
 // one at https://mozilla.org/MPL/2.0/.
 
 using System;
-using Vlingo.Actors.TestKit;
 using Vlingo.Common;
+using Vlingo.Actors.TestKit;
 using Xunit;
 
 namespace Vlingo.Actors.Tests
@@ -27,13 +27,13 @@ public void TestWorldTerminateToStopAllActors()
                 stoppables[idx].CreateChildren();
             }
 
-            testSpecs.untilStart.Completes();
+            testSpecs.untilStart.CompletesWithin(2000);
             testSpecs.untilTerminatingStop = TestUntil.Happenings(12);
             testSpecs.terminating.Set(true);
 
             World.Terminate();
 
-            testSpecs.untilTerminatingStop.Completes();
+            testSpecs.untilTerminatingStop.CompletesWithin(2000);
 
             Assert.Equal(12, testSpecs.terminatingStopCount.Get());
         }
@@ -50,7 +50,7 @@ public void TestStopActors()
                 stoppables[idx].CreateChildren();
             }
 
-            testResults.untilStart.Completes();
+            testResults.untilStart.CompletesWithin(2000);
 
             testResults.untilStop = TestUntil.Happenings(12);
 
@@ -59,13 +59,17 @@ public void TestStopActors()
                 stoppables[idx].Stop();
             }
 
-            testResults.untilStop.Completes();
+            testResults.untilStop.CompletesWithin(2000);
 
             Assert.Equal(12, testResults.stopCount.Get());
 
+            testResults.untilTerminatingStop = TestUntil.Happenings(0);
+
             testResults.terminating.Set(true);
             World.Terminate();
 
+            testResults.untilTerminatingStop.CompletesWithin(2000);
+
             Assert.Equal(0, testResults.terminatingStopCount.Get());
         }
 
@@ -111,7 +115,8 @@ protected internal override void AfterStop()
                 {
                     if (testResults.terminating.Get())
                     {
-                        testResults.terminatingStopCount.IncrementAndGet();
+                        var count = testResults.terminatingStopCount.IncrementAndGet();
+                        Console.WriteLine("TERMINATING AND STOPPED: " + count + " ");
                         testResults.untilTerminatingStop.Happened();
                     }
                     else

src/Vlingo.Actors.Tests/ActorStowDisperseTest.cs

@@ -0,0 +1,116 @@
+// Copyright (c) 2012-2018 Vaughn Vernon. All rights reserved.
+//
+// This Source Code Form is subject to the terms of the
+// Mozilla Public License, v. 2.0. If a copy of the MPL
+// was not distributed with this file, You can obtain
+// one at https://mozilla.org/MPL/2.0/.
+
+using System;
+using Vlingo.Actors.TestKit;
+using Xunit;
+
+namespace Vlingo.Actors.Tests
+{
+    public class ActorStowDisperseTest : ActorsTest
+    {
+        [Fact]
+        public void TestThatStowedMessagesDisperseOnOverride()
+        {
+            var results = new Results(1, 10);
+            var protocols = Protocols.Two<IStowThese, IOverrideStowage>(
+                World.ActorFor(
+                    Definition.Has<StowTestActor>(Definition.Parameters(results), "stow-override"),
+                    new[] { typeof(IStowThese), typeof(IOverrideStowage) }));
+
+            for(var idx=0; idx<10; ++idx)
+            {
+                protocols._1.Stow();
+            }
+
+            protocols._2.Override();
+
+            results.overrideReceived.Completes();
+            results.stowReceived.Completes();
+
+            Assert.Equal(1, results.overrideReceivedCount);
+            Assert.Equal(10, results.stowReceivedCount);
+        }
+
+        [Fact]
+        public void TestThatStowedMessagesDisperseOnCrash()
+        {
+            var results = new Results(1, 10);
+            var protocols = Protocols.Two<IStowThese, IOverrideStowage>(
+                World.ActorFor(
+                    Definition.Has<StowTestActor>(Definition.Parameters(results), "stow-override"),
+                    new[] { typeof(IStowThese), typeof(IOverrideStowage) }));
+
+            for (var idx = 0; idx < 10; ++idx)
+            {
+                protocols._1.Stow();
+            }
+
+            protocols._2.Crash();
+
+            results.overrideReceived.Completes();
+            results.stowReceived.Completes();
+
+            Assert.Equal(1, results.overrideReceivedCount);
+            Assert.Equal(10, results.stowReceivedCount);
+        }
+
+        private class Results
+        {
+            public readonly TestUntil overrideReceived;
+            public int overrideReceivedCount;
+            public readonly TestUntil stowReceived;
+            public int stowReceivedCount;
+            public Results(int overrideReceived, int stowReceived)
+            {
+                this.overrideReceived = TestUntil.Happenings(overrideReceived);
+                this.stowReceived = TestUntil.Happenings(stowReceived);
+            }
+        }
+
+        private class StowTestActor : Actor, IOverrideStowage, IStowThese
+        {
+            private readonly Results results;
+
+            public StowTestActor(Results results)
+            {
+                this.results = results;
+                StowMessages(typeof(IOverrideStowage));
+            }
+
+            public void Crash()
+            {
+                ++results.overrideReceivedCount;
+                results.overrideReceived.Happened();
+                throw new ApplicationException("Intended failure");
+            }
+
+            public void Override()
+            {
+                ++results.overrideReceivedCount;
+                DisperseStowedMessages();
+                results.overrideReceived.Happened();
+            }
+
+            public void Stow()
+            {
+                ++results.stowReceivedCount;
+                results.stowReceived.Happened();
+            }
+        }
+    }
+
+    public interface IOverrideStowage
+    {
+        void Crash();
+        void Override();
+    }
+    public interface IStowThese
+    {
+        void Stow();
+    }
+}

src/Vlingo.Actors.Tests/ActorsTest.cs

@@ -7,6 +7,7 @@
 
 using System;
 using Vlingo.Actors.TestKit;
+using Vlingo.Actors.TestKit;
 
 namespace Vlingo.Actors.Tests
 {

src/Vlingo.Actors.Tests/AddressTest.cs

@@ -5,7 +5,6 @@
 // was not distributed with this file, You can obtain
 // one at https://mozilla.org/MPL/2.0/.
 
-using System;
 using Xunit;
 
 namespace Vlingo.Actors.Tests
@@ -32,12 +31,12 @@ public void TestNameGiven()
         [Fact]
         public void TestNameAndIdGiven()
         {
-            const int id = 123;
+            const long id = 123;
 
             var address = World.AddressFactory.From(id, "test-address");
 
             Assert.NotNull(address);
-            Assert.Equal(123, address.Id);
+            Assert.Equal(id, address.Id);
             Assert.Equal("test-address", address.Name);
 
             var another = World.AddressFactory.From(456, "test-address");