Repository navigation
Optimize Build - #317
Merged
Merged
Optimize Build#317
Conversation
Should prevent memory issues on builds with large JS
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🎭 Playwright Visual Test ReportRun on commit ✅ 22/22 tests passed! 🎉 We didn't detect any visual changes on: All Electric Building (Print Page 1), Mix Building (Merch Mart) (Print Page 1), No Image Building (Print Page 1), All Electric Building, Mix Building (Merch Mart) and 6 more Passed Tests (22)
|
vkoves
marked this pull request as ready for review
September 25, 2026 00:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the gridsome docs state,
<page-query>should be used for pages, and<static-query>for components, and it turns out we've been using the latter a lot on big pages, which has showed up as Netlify out of memory build failures:Future improvement: the
sitemap.xmlgeneration takes 190 seconds, but our URLs don't change that often - might be worth integrating into our build process? ( update: nevermind, the sitemap is near instant, the timestamps are just confusing!)This fixes that by converting pages to the
<page-query>Bonus Bug Fix
Fixed property types page showing types with no buildings
Testing Instructions
Please describe the tests/QA that you did to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Checklist:
Data Update (if applicable):