Skip to content

Optimize Build - #317

Merged
vkoves merged 7 commits into
mainfrom
optimize-build
Sep 25, 2026
Merged

vkoves merged 7 commits into
mainfrom
optimize-build

Conversation

@vkoves

@vkoves vkoves commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

Description

As the gridsome docs state, <page-query> should be used for pages, and <static-query> for components, and it turns out we've been using the latter a lot on big pages, which has showed up as Netlify out of memory build failures:

Before (Flake) After
image image

Future improvement: the sitemap.xml generation takes 190 seconds, but our URLs don't change that often - might be worth integrating into our build process? ( update: nevermind, the sitemap is near instant, the timestamps are just confusing!)

This fixes that by converting pages to the <page-query>

Bonus Bug Fix

Fixed property types page showing types with no buildings

image

Testing Instructions

Please describe the tests/QA that you did to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If I added a large new feature, I added it to the release notes (ReleaseNotes.vue)

Data Update (if applicable):

Should prevent memory issues on builds with large JS
@netlify

netlify Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit ae0e22f
🔍 Latest deploy log https://app.netlify.com/projects/radiant-cucurucho-d09bae/deploys/6ab5c57df8fe850008a1162a
😎 Deploy Preview https://deploy-preview-317--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🎭 Playwright Visual Test Report

Run on commit a8f31c3 at Sep 24, 2026, 7:54 PM CDT

✅ 22/22 tests passed! 🎉

We didn't detect any visual changes on: All Electric Building (Print Page 1), Mix Building (Merch Mart) (Print Page 1), No Image Building (Print Page 1), All Electric Building, Mix Building (Merch Mart) and 6 more

Passed Tests (22)
  • All Electric Building (Print Page 1)
  • Mix Building (Merch Mart) (Print Page 1)
  • No Image Building (Print Page 1)
  • All Electric Building
  • Mix Building (Merch Mart)
  • No Image Building
  • Building Owner (IIT)
  • Search
  • Home
  • All Electric Page
  • Ward 47

📦 Download Full Report | 🔍 View Run Details

@vkoves
vkoves marked this pull request as ready for review September 25, 2026 00:41
@vkoves vkoves changed the title Optimz Optimize Build Sep 25, 2026
@vkoves
vkoves merged commit 9340750 into main Sep 25, 2026
8 checks passed
@vkoves
vkoves deleted the optimize-build branch September 25, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant