Skip to content

read telegram token from file.#15

Open
shizunge wants to merge 2 commits intovjFaLk:masterfrom
shizunge:read-token-file
Open

read telegram token from file.#15
shizunge wants to merge 2 commits intovjFaLk:masterfrom
shizunge:read-token-file

Conversation

@shizunge
Copy link
Contributor

Docker does not use environment variables to manage secrets. Instead docker mount secrets as a file in the container.

This change add a new option TELEGRAM_BOT_TOKEN_FILE to read token from a file and it takes precedence.

@vjFaLk
Copy link
Owner

vjFaLk commented Mar 8, 2022

Hey @shizunge you can add env vars when creating a container. That's how I use it.

Or did I misunderstand your point?

@shizunge
Copy link
Contributor Author

shizunge commented Mar 8, 2022

We can use environment variables.
But docker secrets is a better way to manage sensitive data than environment variables. (I am using docker)

https://docs.docker.com/engine/swarm/secrets/
https://stackoverflow.com/questions/44615837/why-is-docker-secrets-more-secure-than-environment-variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants