fix(api): node renamed witness→validator on read shapes - #16
Merged
Conversation
The viz-cpp-node witness→validator migration renamed the fields the node returns from the read RPCs, but the SDK types still declared the old names: - DynamicGlobalProperties.current_witness → current_validator (database_api.get_dynamic_global_properties) - Block.witness → validator - Block.witness_signature → validator_signature (database_api.get_block / get_block_header) Add the new names as primary and keep the old ones as @deprecated aliases; widen getBlockHeader's Pick to include validator. The write path (op-schema, tx builder) already used the new names — this fixes only the lagging read shapes. Verified against live node.viz.cx: get_block_header returns { previous, timestamp, validator, ... } and dgp returns current_validator. tsc --noEmit clean; 232 unit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The viz-cpp-node
witness→validatormigration renamed the fields the node returns from the read RPCs, but the SDK types still declared the old names:DynamicGlobalProperties.current_witnesscurrent_validatorget_dynamic_global_propertiesBlock.witnessvalidatorget_block/get_block_headerBlock.witness_signaturevalidator_signatureget_blockChange
@deprecatedaliases.getBlockHeader'sPickto includevalidator.The write path (op-schema, tx builder) already used the new names — this fixes only the lagging read shapes.
Verified against live
node.viz.cxget_block_header→{ previous, timestamp, validator, transaction_merkle_root, extensions }(nowitness)get_dynamic_global_properties→current_validatorget_block→validator,validator_signaturetsc --noEmitclean; 232 unit tests pass.