Fix issue #9 (negate_sequence bug) #10
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review my fix for issue #9.
I use the stripped version of the word (lowered and stripped of delims) to see if it equals
"not","cannot","no", or if it ends with"n't". If any of these are true, thennegationis negated.This fixes both issues of:
negationbeing changed when seeing words containing["no", "not", "n't"](e.g."know")negationnot being changed when seeing things that are uppercase that should triggernegationbeing changed but don't. (i.e., capital"DON'T")I added the word
"cannot"because if I checkedif stripped.endswith("not")then that would match words like"knot"and"whatnot". I'm assuming negation is wanted when observing the word"cannot". If this is a wrong assumption please let me know.Cheers,
@sm1th