Skip to content

use namespace in cache_it_json and avoid exception when invalidating a namespace #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dariosky wants to merge 3 commits into
base: master
Choose a base branch
from
Open

use namespace in cache_it_json and avoid exception when invalidating a namespace #41

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc48b23
Handle invalidating a namespace without keys
dariosky Sep 29, 2016
a0b0f38
cache_it_json was ignoring the namespace
dariosky Sep 29, 2016
6fa67ef
When nothing to delete just return None
dariosky Sep 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions redis_cache/rediscache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,11 @@ def expire_namespace(self, namespace):
"""
namespace = self.namespace_key(namespace)
all_members = list(self.connection.keys(namespace))
with self.connection.pipeline() as pipe:
pipe.delete(*all_members)
pipe.execute()

return len(self), len(all_members)
if all_members:
with self.connection.pipeline() as pipe:
pipe.delete(*all_members)
pipe.execute()
return len(self), len(all_members)

def isexpired(self, key):
"""
Expand Down Expand Up @@ -375,7 +375,7 @@ def cache_it_json(limit=10000, expire=DEFAULT_EXPIRY, cache=None, namespace=None
:return: decorated function
"""
return cache_it(limit=limit, expire=expire, use_json=True,
cache=cache, namespace=None)
cache=cache, namespace=namespace)


def to_unicode(obj, encoding='utf-8'):
Expand Down