-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: test oxc module runner transform #7646
Draft
hi-ogawa
wants to merge
39
commits into
vitest-dev:main
Choose a base branch
from
hi-ogawa:chore-oxc-module-runner-transform
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore: test oxc module runner transform #7646
hi-ogawa
wants to merge
39
commits into
vitest-dev:main
from
hi-ogawa:chore-oxc-module-runner-transform
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
7 tasks
4e82d36
to
6b5219a
Compare
6b5219a
to
c2b0c34
Compare
test: workaround default import identity chore: update vite/oxc-transform test: update stack trace chore: vitepress with ROLLDOWN_OPTIONS_VALIDATION=loose
c2b0c34
to
b14753a
Compare
87239ea
to
09eb6ab
Compare
graphite-app bot
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Mar 12, 2025
There wasn't a test case for this on Vite, but missing re-export deps is spotted as a test case on Vitest vitest-dev/vitest#7646. I'll add a test case on Vite vitejs/rolldown-vite#85 and the same one is added here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Base branch #7509
Diff sheremet-va/vitest@feat/rolldown-support...hi-ogawa:vitest:chore-oxc-module-runner-transform
Testing rolldown-vite from vitejs/rolldown-vite#85
notes
default
export value identify oxc-project/oxc#9645Plain js is transformed by oxc, so comments are all stripped. This was already the case for ts files due to esbuild, so it's not likely this change significantly affects users.
something wrong with
pnpm -C test/cli test /git-changed
andtest/cli/fixtures/git-changed/related
fix(transformer/module_runner): handle re-export as deps oxc-project/oxc#9696vitest/test/cli/fixtures/git-changed/related/src/sourceC.ts
Lines 1 to 2 in b14753a
test/coverage-test/fixtures/src/load-outside-vite.cjs
;
somehow increasesbranches
count. This is likely not essential and it just got manifested due to plain js being transformed (see 3rd note above).test/coverage-test/test/pre-transpiled-source.test.ts
new Worker(new URL(..), { type: "module" })
and OXC finally adding new lines somewhere. this is probably fine and also the bug might be elsewhere.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.