Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test oxc module runner transform #7646

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Mar 10, 2025

Description

Base branch #7509
Diff sheremet-va/vitest@feat/rolldown-support...hi-ogawa:vitest:chore-oxc-module-runner-transform

Testing rolldown-vite from vitejs/rolldown-vite#85

notes

someFn()
      ^  [before]
^ [after]

// re-exporting for deep changed detection
export { A } from './sourceA'

  • v8 coverage
    • test/coverage-test/fixtures/src/load-outside-vite.cjs
      • oxc transform appending ; somehow increases branches count. This is likely not essential and it just got manifested due to plain js being transformed (see 3rd note above).
    • test/coverage-test/test/pre-transpiled-source.test.ts
      • no change in functions/branches count, so this is probably fine.
    • web worker
      • minor single line coverage difference likely due to both Vite and Vitest messing with new Worker(new URL(..), { type: "module" }) and OXC finally adding new lines somewhere. this is probably fine and also the bug might be elsewhere.
    • vue
      • coverage already fluctuates between providers, so this is probably fine.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b14753a
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67d0f99cd8cc32000884c14c
😎 Deploy Preview https://deploy-preview-7646--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa force-pushed the chore-oxc-module-runner-transform branch from 4e82d36 to 6b5219a Compare March 12, 2025 03:00
@hi-ogawa hi-ogawa force-pushed the chore-oxc-module-runner-transform branch from 6b5219a to c2b0c34 Compare March 12, 2025 03:01
test: workaround default import identity

chore: update vite/oxc-transform

test: update stack trace

chore: vitepress with ROLLDOWN_OPTIONS_VALIDATION=loose
@hi-ogawa hi-ogawa force-pushed the chore-oxc-module-runner-transform branch from 87239ea to 09eb6ab Compare March 12, 2025 07:03
graphite-app bot pushed a commit to oxc-project/oxc that referenced this pull request Mar 12, 2025
There wasn't a test case for this on Vite, but missing re-export deps is spotted as a test case on Vitest vitest-dev/vitest#7646.

I'll add a test case on Vite vitejs/rolldown-vite#85 and the same one is added here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants