Enhance dbinfo sub-command with column names and global variables #70
Conversation
rohit-nayak-ps
force-pushed
the
rohit/dbinfo
branch
2 times, most recently
from
297a90c to
f427fd6
Compare
rohit-nayak-ps
changed the title
go/cmd/dbinfo.go
Outdated
| }, | ||
| } | ||
|
|
||
| cmd.Flags().StringVarP(&vtParams.Host, "host", "", "127.0.0.1", "Database host") | ||
| cmd.Flags().IntVarP(&vtParams.Port, "port", "", 3306, "Database port") | ||
| cmd.Flags().StringVarP(&vtParams.Uname, "user", "", "root", "Database user") | ||
| cmd.Flags().StringVarP(&vtParams.Pass, "password", "", "", "Database password") | ||
| cmd.Flags().StringVarP(&vtParams.DbName, "database", "", "", "Database name") | ||
| cmd.Flags().StringVarP(&vtParams.DbName, "database", "", "sakila", "Database name") |
There was a problem hiding this comment.
we probably shouldn't use sakila as the default value, right?
go/dbinfo/dbinfo.go
Outdated
| Name string `json:"name"` | ||
| Type string `json:"type"` | ||
| KeyType string `json:"keyType,omitempty"` | ||
| IsNullable bool `json:"isNullable"` |
There was a problem hiding this comment.
nitpick: could we slim up the json output? like removing isNullable for false values?
go/dbinfo/dbinfo.go
Outdated
| Tables []TableInfo `json:"tables"` | ||
| FileType string `json:"fileType"` | ||
| Tables []*TableInfo `json:"tables"` | ||
| GlobalVariables *map[string]string `json:"globalVariables"` |
There was a problem hiding this comment.
why a reference to a map? maps are already sent around by reference, so I'm confused to why
There was a problem hiding this comment.
Had started with a different data structure, should have removed the reference once I used maps ... Did.
|
|
||
| func (dbh *DBHelper) getGlobalVariables() (*map[string]string, error) { | ||
| // Currently only use simple regex to match the variable names | ||
| // If the variable name contains ".*" then it is treated as a regex, else exact match |
There was a problem hiding this comment.
seems premature to add the regex functionality, since we are not using it, or have any plans on using it at the moment
|
we should also add something to the main README about this functionality |
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
force-pushed
the
rohit/dbinfo
branch
from
e4b292d to
2186754
Compare
Signed-off-by: Rohit Nayak <[email protected]>
Added some information there. PTAL and modify if required. Also I have auto-wrap setup for md files, if that is not desired I can revert and only update with my changes ... |
schematodbinfotodos