Add table row count to summary output #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
commented
Nov 20, 2024
| @@ -53,9 +54,11 @@ func keysCmd() *cobra.Command { | |||
| return cmd | |||
| } | |||
|
|
|||
| const allowedInputTypes = "'sql', 'mysql-log' or 'vtgate-log'" | |||
There was a problem hiding this comment.
Just noticed the error messages were incomplete, so added this to the PR.
rohit-nayak-ps
requested review from
systay and
frouioui
and removed request for
systay
systay
reviewed
Nov 21, 2024
systay
reviewed
Nov 21, 2024
systay
reviewed
Nov 21, 2024
systay
reviewed
Nov 21, 2024
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
…schema info and deduce that type from the json input itself Signed-off-by: Rohit Nayak <[email protected]>
systay
reviewed
Nov 22, 2024
Signed-off-by: Rohit Nayak <[email protected]>
systay
reviewed
Nov 22, 2024
systay
reviewed
Nov 22, 2024
systay
reviewed
Nov 22, 2024
systay
reviewed
Nov 22, 2024
systay
approved these changes
Nov 22, 2024
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced summarize
Added a new flag
schema-info-pathto specify the output of thevt schemacommand. It updates the table summary with the number of rows per table and adds it to the summary output.new schema sub-command
Added a
vt schemacommand that takes connection information to a running MySQL instance and gets (for now) the number of rows per table from theinformation_schema. It outputs a schema info json file for ingestion bysummarize.We will enhance this to get additional info like PKs, indexes, FKs, Column info, Selectivity (in the future) etc.
Miscellaneous
usage_countdirective which will allow users to specify the number of times a query was called. This is a shortcut to having to specify the same query / query pattern multiple times to simulate real world usagesakilarelated test filesTodos