-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vexplain to protect the log fields from concurrent writes #17460
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Harshit Gangal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17460 +/- ##
==========================================
- Coverage 67.67% 67.66% -0.01%
==========================================
Files 1583 1584 +1
Lines 254363 254368 +5
==========================================
- Hits 172140 172127 -13
- Misses 82223 82241 +18 ☔ View full report in Codecov by Sentry. |
I think v21 has the same issue in |
It does, I believe it do qualify for the backport. |
Description
The new added planner e2e tests were flaky on
vexplain
as the fields used to log the shard and rows information were not protected from the concurrent writes.This PR fixes it.
Backport to v21: Fixes a real issue that panic on concurrent write.
Related Issue(s)
Checklist
Deployment Notes