Skip to content

Conversation

@keller-mark
Copy link
Member

@keller-mark keller-mark commented Sep 10, 2025

Towards scverse/spatialdata#974

Implementing here in vitessce.data_utils initially to be able to test things out

TODO:

  • Fix rounding issues in test
  • Provide large (or small) example points dataset in unit test (crop/filter current test fixture?)
  • Store feature_key codes column name in metadata
  • Store bounding box metadata via parquet metadata (rather than sdata.attrs)?

@keller-mark keller-mark changed the title Keller mark/sdata zorder Utilities for sorting spatialdata points along z-order curve Sep 10, 2025
@keller-mark
Copy link
Member Author

keller-mark commented Oct 2, 2025

Note the custom .attrs for the point element are not written to disk. See https://github.com/scverse/spatialdata/blob/aeef0cc3ebd7c10a7ed17b84415213bb259a5f4b/src/spatialdata/_io/format.py#L116 Need to either make a PR to spatialdata or store the attributes somewhere else (e.g., the parquet schema metadata?)

For now/testing, I have manually edited the .zattrs file to include the bounding_box property:
Screenshot 2025-10-02 at 3 34 34 PM

@keller-mark keller-mark marked this pull request as ready for review October 20, 2025 17:24
@keller-mark keller-mark merged commit 324a5b0 into main Oct 30, 2025
14 checks passed
@keller-mark keller-mark deleted the keller-mark/sdata-zorder branch October 30, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants