Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify assetsInclude #4955

Merged
merged 1 commit into from
Sep 17, 2021
Merged

docs: clarify assetsInclude #4955

merged 1 commit into from
Sep 17, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 17, 2021

Description

Closes #4948 and maybe #4953

assetsInclude is often mistaken as an array of file extensions, which internally it's passed to @rollup/pluginutils's createFilter function, so specifying file extensions doesn't work. Clarified as picomatch patterns instead.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the documentation Improvements or additions to documentation label Sep 17, 2021
@antfu antfu merged commit 05fae60 into vitejs:main Sep 17, 2021
@bluwy bluwy deleted the docs-clarify-assetsinclude branch September 17, 2021 08:48
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@bluwy @aleclarson
docs: clarify assetsInclude (vitejs#4955)
e57ed5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

custom assetsInclude take no effect
4 participants
@bluwy @haoqunjiang @Shinigami92 @antfu