Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add rolldown chapter #19680

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

TheAlexLichter
Copy link
Contributor

@TheAlexLichter TheAlexLichter commented Mar 19, 2025

Description

This PR introduces a new documentation page that details Vite's integration with Rolldown. The added page aims to educate users about using it via the rolldown-vite package and giving information on why Vite users should give it a try and which limitations might be expected.

Related PRs

vitejs#87

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label Mar 19, 2025
sapphi-red
sapphi-red previously approved these changes Mar 19, 2025
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red added this to the 6.3 milestone Mar 19, 2025
Comment on lines 17 to 23
1. **Unification**: Vite currently uses esbuild for dependency pre-bundling and Rollup for production builds. Rolldown aims to unify these into a single, high-performance bundler that can be used for both purposes, reducing complexity.

2. **Performance**: Rolldown's Rust-based implementation offers significant performance improvements over JavaScript-based bundlers. While specific benchmarks may vary by project size and complexity, early tests show promising speed increases compared to Rollup.

3. **Compatibility**: Rolldown is designed to be compatible with the Rollup plugin ecosystem, minimizing migration friction for Vite projects.

4. **Additional Features**: Rolldown will provide features like improved chunk splitting and better support for Vite's development and production workflows.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean instead of the content or in addition? I was also wondering how much duplicates we want in the Vite docs regarding the "why"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having a Why section is a good idea here. Maybe we could remove Compatibility and Additional Features. As these aren't reasons we move to rolldown, we could extend rollup for these. I think the first two are more inline with the Why we are building rolldown section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then I will leave the first two in and add a "read more" link 👍🏻

Comment on lines +81 to +87
Since this is an experimental integration, you may encounter issues. If you do, please report them in the [`vitejs/rolldown-vite`](https://github.com/vitejs/rolldown-vite) repository, **not the main Vite repository**.

When [reporting issues](https://github.com/vitejs/rolldown-vite/issues/new), please follow the issue template and provide:

- A minimal reproduction of the issue
- Your environment details (OS, Node version, package manager)
- Any relevant error messages or logs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sapphi-red do you think it is valuable to have a Rolldown Vite discussion in the main Vite repo to gather feedback? Thinking on general feedback (even things like "it worked great!) that may be lost if we only link to the issues tracker here.

@TheAlexLichter it could be a good moment to also plug the Rolldown discord in this section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent idea, will add a comment regarding the Discord 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants