-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add rolldown chapter #19680
base: main
Are you sure you want to change the base?
docs: add rolldown chapter #19680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
docs/guide/rolldown.md
Outdated
1. **Unification**: Vite currently uses esbuild for dependency pre-bundling and Rollup for production builds. Rolldown aims to unify these into a single, high-performance bundler that can be used for both purposes, reducing complexity. | ||
|
||
2. **Performance**: Rolldown's Rust-based implementation offers significant performance improvements over JavaScript-based bundlers. While specific benchmarks may vary by project size and complexity, early tests show promising speed increases compared to Rollup. | ||
|
||
3. **Compatibility**: Rolldown is designed to be compatible with the Rollup plugin ecosystem, minimizing migration friction for Vite projects. | ||
|
||
4. **Additional Features**: Rolldown will provide features like improved chunk splitting and better support for Vite's development and production workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be good to link to https://rolldown.rs/about#why-we-are-building-rolldown here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean instead of the content or in addition? I was also wondering how much duplicates we want in the Vite docs regarding the "why"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having a Why section is a good idea here. Maybe we could remove Compatibility and Additional Features. As these aren't reasons we move to rolldown, we could extend rollup for these. I think the first two are more inline with the Why we are building rolldown section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, then I will leave the first two in and add a "read more" link 👍🏻
Since this is an experimental integration, you may encounter issues. If you do, please report them in the [`vitejs/rolldown-vite`](https://github.com/vitejs/rolldown-vite) repository, **not the main Vite repository**. | ||
|
||
When [reporting issues](https://github.com/vitejs/rolldown-vite/issues/new), please follow the issue template and provide: | ||
|
||
- A minimal reproduction of the issue | ||
- Your environment details (OS, Node version, package manager) | ||
- Any relevant error messages or logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sapphi-red do you think it is valuable to have a Rolldown Vite discussion in the main Vite repo to gather feedback? Thinking on general feedback (even things like "it worked great!) that may be lost if we only link to the issues tracker here.
@TheAlexLichter it could be a good moment to also plug the Rolldown discord in this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent idea, will add a comment regarding the Discord 👍🏻
Co-authored-by: Alexander Lichter <[email protected]>
Description
This PR introduces a new documentation page that details Vite's integration with Rolldown. The added page aims to educate users about using it via the
rolldown-vite
package and giving information on why Vite users should give it a try and which limitations might be expected.Related PRs
vitejs#87