-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add useAtYourOwnRisk_mutateSwcOptions option #255
base: main
Are you sure you want to change the base?
Conversation
I think in the same way that we allow editing other low level options, we could also directly add a |
I choose the mutate API because I don't want to have to deal with merging, it's always complex to have a good default for arrays. I can change the api to a version where you return the object, but mutating feels simpler (see the example) and it's always safe because all options a generated on every request |
Sounds good to me. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming bike-shed aside, looks good to me.
For a long time I asked people to do a patch to get access to feature I don't want to maintain (hello not yet stable decorators)
I think this option will create less issues/PRs while still having the benefit that users know they are in a non standard setup.