This repository was archived by the owner on Oct 9, 2018. It is now read-only.
Fix: instrumentation breaks new(require('foo'))(args)
#19
+40
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a missing parenthesis when generating code for a new() statement
applied to an expression, like the example:
new(require('foo'))(args)
which used to generate
new require('foo')(args)
resulting in the returned function being called without 'new'.
I have no idea why on earth TOK_LP calls instrument_function_call; it
seems to treat all parethesized expressions as function calls, but I
didn't feel like investigating that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a missing parenthesis when generating code for a new() statement applied to an expression, like the example:
which used to generate
resulting in the returned function being called without 'new'.
I have no idea why on earth TOK_LP calls instrument_function_call; it seems to treat all parethesized expressions as function calls, but I didn't feel like investigating that.