Add Rule.Equal method. #1095
Open
Add Rule.Equal method. #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeing this failure: Seems to have been present in other recent PRs, so apparently not introduced here. |
stephanreiter
force-pushed
the
add-rule-equal
branch
from
be83fa0 to
bb01d76
Compare
stephanreiter
pushed a commit
to stephanreiter/netlink
that referenced
this pull request
Jun 29, 2025
When reading rules, makes sure to populate the type field of Rule. Also adds a l3mdev flag to Rule, reads it when listing rules, sets it when updating rules, and makes sure it is taken into account when comparing rules using Equal as introduced in vishvananda#1095.
This should be fixed now that #1106 is merged. Could you please rebase your branch and try again? |
stephanreiter
pushed a commit
to stephanreiter/netlink
that referenced
this pull request
Jul 22, 2025
When reading rules, makes sure to populate the type field of Rule. Also adds a l3mdev flag to Rule, reads it when listing rules, sets it when updating rules, and makes sure it is taken into account when comparing rules using Equal as introduced in vishvananda#1095.
stephanreiter
force-pushed
the
add-rule-equal
branch
from
bb01d76 to
e8c1398
Compare
This adds an implementation of Rule.Equal (and RulePortRange.Equal, RuleUIDRange.Equal) which allows us to compare two Rule objects.
stephanreiter
force-pushed
the
add-rule-equal
branch
from
e8c1398 to
6a8c071
Compare
stephanreiter
pushed a commit
to stephanreiter/netlink
that referenced
this pull request
Jul 22, 2025
When reading rules, makes sure to populate the type field of Rule. Also adds a l3mdev flag to Rule, reads it when listing rules, sets it when updating rules, and makes sure it is taken into account when comparing rules using Equal as introduced in vishvananda#1095.
|
Thank you for letting me know. All green now. |
stephanreiter
pushed a commit
to stephanreiter/netlink
that referenced
this pull request
Jul 22, 2025
When reading rules, makes sure to populate the type field of Rule. Also adds a l3mdev flag to Rule, reads it when listing rules, sets it when updating rules, and makes sure it is taken into account when comparing rules using Equal as introduced in vishvananda#1095.
stephanreiter
pushed a commit
to stephanreiter/netlink
that referenced
this pull request
Jul 22, 2025
When reading rules, makes sure to populate the type field of Rule. Also adds a l3mdev flag to Rule, reads it when listing rules, sets it when updating rules, and makes sure it is taken into account when comparing rules using Equal as introduced in vishvananda#1095.
stephanreiter
pushed a commit
to stephanreiter/netlink
that referenced
this pull request
Jul 22, 2025
When reading rules, makes sure to populate the type field of Rule. Also adds a l3mdev flag to Rule, reads it when listing rules, sets it when updating rules, and makes sure it is taken into account when comparing rules using Equal as introduced in vishvananda#1095.
stephanreiter
pushed a commit
to stephanreiter/netlink
that referenced
this pull request
Jul 22, 2025
When reading rules, makes sure to populate the type field of Rule. Also adds a l3mdev flag to Rule, reads it when listing rules, sets it when updating rules, and makes sure it is taken into account when comparing rules using Equal as introduced in vishvananda#1095.
stephanreiter
pushed a commit
to stephanreiter/netlink
that referenced
this pull request
Jul 22, 2025
When reading rules, makes sure to populate the type field of Rule. Also adds a l3mdev flag to Rule, reads it when listing rules, sets it when updating rules, and makes sure it is taken into account when comparing rules using Equal as introduced in vishvananda#1095.
stephanreiter
pushed a commit
to stephanreiter/netlink
that referenced
this pull request
Jul 22, 2025
When reading rules, makes sure to populate the type field of Rule. Also adds a l3mdev flag to Rule, reads it when listing rules, sets it when updating rules, and makes sure it is taken into account when comparing rules using Equal as introduced in vishvananda#1095.
stephanreiter
pushed a commit
to stephanreiter/netlink
that referenced
this pull request
Jul 22, 2025
When reading rules, makes sure to populate the type field of Rule. Note that an unspecified type is interpreted as UNICAST, for example, when adding a rule. To make sure that a rule with unspecified type, which was just added, compares equal to that rule being read back, we we update Rule.Equal to treat unspecified and UNICAST types as equal. Also adds a l3mdev flag to Rule, reads it when listing rules, sets it when updating rules, and makes sure it is taken into account when comparing rules using Equal as introduced in vishvananda#1095.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an implementation of
Rule.Equal(andRulePortRange.Equal,RuleUIDRange.Equal) which allows us to compare twoRuleobjects.It fixes #1094