Icon layer size #9736
Merged
Icon layer size #9736
+77
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ious size properties
|
I added tests to cover the new sizeBasis property. Any feedback is appreciated |
felixpalmer
requested changes
Sep 22, 2025
test/render/test-cases/icon-layer.js
Outdated
| data: points, | ||
| iconAtlas: './test/data/rectangle.png', | ||
| iconMapping: { | ||
| rectangle: { |
There was a problem hiding this comment.
As is, the test doesn't prove much as you only have a single image. It could be made to pass even without the fix this PR adds just by adjusting the size
It would be better if your test image atlas had 4 road signs like you had in your issue which have different heights and the output would then show that they are all indeed the same width.
felixpalmer
reviewed
Sep 30, 2025
test/render/test-cases/icon-layer.js
Outdated
| iconMapping: { | ||
| tall: {x: 0, y: 0, width: 40, height: 80, mask: true, anchorY: 40}, | ||
| wide: {x: 40, y: 0, width: 80, height: 40, mask: true, anchorY: 20}, | ||
| square: {x: 120, y: 0, width: 60, height: 60, mask: true, anchorY: 30}, |
There was a problem hiding this comment.
Any reason you have mask: true? I would remove it
There was a problem hiding this comment.
Good catch, mask was not needed. I have removed it and updated the golden image so the tests should pass now. Thanks!
Merged
felixpalmer
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #9694