Support dynamic Gaussian updates - #757
Merged
Merged
Conversation
…king helpers - Assemble the buffer locally and store it via a single property assignment, instead of resizing through _ensure_buffer_size (which queued an extra all-default buffer message on count changes, flashing white gaussians on clients) and calling _queue_update directly (which bypassed the removed-handle guard and could resurrect removed nodes). - Extract _pack_centers/_pack_covariances/_pack_rgba helpers shared by set_gaussians and the four per-property setters, so the 32-byte buffer layout is encoded in one place. - Add tests: round-trip through property getters (incl. count change and N=0), exactly one queued buffer update on resize with no aliasing, and RuntimeError after remove().
brentyi
approved these changes
Aug 11, 2026
brentyi
left a comment
brentyi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @maxwildersmith!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
set_gaussiansfunction to update the Gaussians in a Gaussian Splat handle rather than needed to manually update the buffer, since these buffer updates can occasionally glitch and stop rendering.