-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Assert-MockCalled
#37
Conversation
Position 1: CommandName | ||
Position 2: Times | ||
#> | ||
function Convert-AssertMockCalled |
Check warning
Code scanning / PSScriptAnalyzer
Unable to determine parameter set used by example 1 for the function Convert-AssertMockCalled Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
===================================
- Coverage 99% 99% -1%
===================================
Files 31 33 +2
Lines 1252 1341 +89
===================================
+ Hits 1249 1337 +88
- Misses 3 4 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 14 files at r1, 1 of 1 files at r2, 9 of 9 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Github-advanced-security[bot])
source/Private/Convert-AssertMockCalled.ps1
line 3 at r3 (raw file):
<# .SYNOPSIS Converts a command `Assert-MockCalled` to `Should -Invoke`.
Suggestion:
Converts a command `Assert-MockCalled` to `Should -Invoke` or `Should-Invoke`.
Position 1: CommandName | ||
Position 2: Times | ||
#> | ||
function Convert-AssertMockCalled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Github-advanced-security[bot])
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Assert-MockCalled
toShould -Invoke
#36Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
DSC Community Testing Guidelines.
This change is