Feat: Add Tree Generation to World Map #107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new `StructureGenerationStep` to the world generation process. This step is responsible for populating the world with structures after the initial tile generation is complete. The first structure added is the `TreeStructure`. Trees are placed on `GrassTile`s based on the output of a seeded `OpenSimplexNoise` function. This ensures that the tree placement is deterministic and repeatable for a given world seed, while also creating varied and natural-looking densities of trees across the landscape. Key changes: - Created `StructureGenerationStep` to handle structure placement. - Created `StructureNoiseGenerator` to provide deterministic noise for structure placement. - Integrated the new generation step into the `Zone` and `MainWorldGenerationStrategy`. - Added logic to place `TreeStructure`s on unoccupied `GrassTile`s. - Addressed compilation errors by fixing access modifiers and constructor calls. - Responded to code review feedback by extracting magic numbers into constants and adding newlines to new files.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This commit introduces a new `StructureGenerationStep` to the world generation process. This step is responsible for populating the world with structures after the initial tile generation is complete. The first structure added is the `TreeStructure`. Trees are placed on `GrassTile`s based on the output of a seeded `OpenSimplexNoise` function. This ensures that the tree placement is deterministic and repeatable for a given world seed, while also creating varied and natural-looking densities of trees across the landscape. Key changes: - Created `StructureGenerationStep` to handle structure placement. - Created `StructureNoiseGenerator` to provide deterministic noise for structure placement. - Integrated the new generation step into the `Zone` and `MainWorldGenerationStrategy`. - Added logic to place `TreeStructure`s on unoccupied `GrassTile`s. - Addressed compilation errors by fixing access modifiers and constructor calls. - Responded to code review feedback by extracting magic numbers into constants and adding newlines to new files. - Fixed all failing tests by introducing a `TestMapGenerationStrategy` and configuring the `GameStateSerializer` to be test-aware, resolving persistent build issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new structure generation step to the world map generation process. It adds trees to grass tiles deterministically, with varying densities to create natural-looking patches of forest.
PR created automatically by Jules for task 17099957544129548334 started by @Lunkle