Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR adds a new card, Flame Circle, that deals 4 damage to all enemies within a 3-tile radius. It also includes the necessary underlying query and expression logic to support this and future area-of-effect cards.


PR created automatically by Jules for task 8877811083958809200 started by @Lunkle

Adds a new card, Flame Circle, that deals 4 damage to all enemies within a 3-tile radius.

This change introduces a reusable and extensible system for area-of-effect cards by adding the following components:

- `TilesInRadiusQuery`: A performant query that finds all tiles within a given radius using a breadth-first search.
- `ActorsOnTilesQuery`: A query that finds all actors on a given set of tiles.
- `DamageActorsExpression`: An expression that applies damage to a list of actors returned by a query.

The `CardPlayer` class has been updated to implement the `Target` interface, making it eligible to be targeted by card effects. The `GameStateSerializer` has also been updated to handle the new `CardExpression` classes.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@Lunkle Lunkle marked this pull request as ready for review December 30, 2025 17:36
Lunkle and others added 5 commits December 30, 2025 12:45
Deleted a resolved or obsolete TODO comment regarding the Rewind card's processing phase in GameCard.java.
The Cycle & Search beginner deck now includes the FLAME_CIRCLE card, providing it with an initial card instead of being empty.
Updated DamageActorsExpression and ActorsOnTilesQuery to operate on the Actor type rather than CardPlayer. This change generalizes the queries and expressions to support a broader range of actor types, improving flexibility for future features.
@Lunkle Lunkle merged commit 600bdd9 into main Dec 31, 2025
1 check passed
@Lunkle Lunkle deleted the feature/flame-circle-card-8877811083958809200 branch December 31, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants