Refactor: Merge Intents and Expressions into a Unified Effect System #101
Conversation
Refactored the card logic to merge the functionality of `Intents` and `Expressions` into a single `CardExpression` hierarchy. - Modified the `CardExpression` interface to produce a list of `Effect` objects directly, removing the need for an intermediate `Intent` layer. - Created new `Effect` classes to replicate the logic of the old `Intent` classes. - Refactored all `CardExpression` implementations to use the new `effects()` method. - Updated all consumers of `CardExpression` to use the new `effects()` method. - Removed the now-obsolete `intent` package. This change simplifies the card logic, reduces boilerplate, and aligns the card effect system with the existing query system for dynamic targeting.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Lunkle
deleted the
refactor/merge-intents-expressions-1029494278130222817
branch
This refactoring merges the functionality of
IntentsandExpressionsinto a singleCardExpressionhierarchy. TheCardExpressioninterface now produces a list ofEffectobjects directly, eliminating the intermediateIntentlayer. This change simplifies the card logic and aligns it with the existing query system for dynamic targeting.PR created automatically by Jules for task 1029494278130222817 started by @Lunkle