fix(iot): disable virtual TPM on VMs that don't need it - #12354
Merged
Conversation
IoT tests don't exercise TPM or measured-boot functionality, but virt-install auto-adds a vTPM for UEFI boots on modern os-variants. A Fedora 44 SELinux userspace regression (selinux-policy 45.8-1) breaks swtpm-selinux's CIL policy compilation (RHBZ#2511086), leaving /usr/bin/swtpm mislabeled and unable to exec under libvirt. This fails every UEFI VM boot in CI. Since the vTPM was never needed, explicitly disable it instead of waiting for the swtpm fix to reach stable repos. iot-simplified-installer.sh is left as-is because it tests encrypted root (coreos.inst.crypt_root=1) which requires TPM emulation. See also: fedora-iot/greenboot-rs#193 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: djach7 <djachimo@redhat.com>
knecasov
approved these changes
Aug 11, 2026
knecasov
left a comment
knecasov
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thank you very much for changes!
Collaborator
Author
|
/test-f44-iot |
Collaborator
Author
|
/test-f45-iot |
Collaborator
Author
|
f45 iot test failures are unrelated to this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IoT tests don't exercise TPM or measured-boot functionality, but virt-install auto-adds a vTPM for UEFI boots on modern os-variants. A Fedora 44 SELinux userspace regression (selinux-policy 45.8-1) breaks swtpm-selinux's CIL policy compilation (RHBZ#2511086), leaving /usr/bin/swtpm mislabeled and unable to exec under libvirt. This fails every UEFI VM boot in CI.
Since the vTPM was never needed, explicitly disable it instead of waiting for the swtpm fix to reach stable repos.
iot-simplified-installer.sh is left as-is because it tests encrypted root (coreos.inst.crypt_root=1) which requires TPM emulation.
See also: fedora-iot/greenboot-rs#193