feat: quark builder with cli #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofvo
force-pushed
the
builder-leofvo
branch
2 times, most recently
from
9cd2ebd to
92fe82e
Compare
sameo
reviewed
Apr 23, 2022
src/quardle/mod.rs
Outdated
| .arg(format!("{}kernel/.config", QUARK_CONFIG_DIR)) | ||
| .output() | ||
| .expect("failed to copy kernel config"); | ||
|
|
Contributor
There was a problem hiding this comment.
You need to make oldconfig after the copy. Make sure it runs without needing any user interaction.
Contributor
Author
There was a problem hiding this comment.
What should be expected from make oldconfig ? It seems to make minor change to .config file.
Contributor
There was a problem hiding this comment.
You need to run make oldconfig locally and use the generated .config. Or call make olddefconfig as it will automatically pick the defaults values.
leofvo
force-pushed
the
builder-leofvo
branch
3 times, most recently
from
b0e6430 to
c77302b
Compare
added: - makefile to simplify testing - basic cli with clap - quardle first minimal struct Signed-off-by: leofvo <[email protected]>
leofvo
force-pushed
the
builder-leofvo
branch
2 times, most recently
from
794a31c to
1e92ff1
Compare
- new: instanciate quardle
- build: build quardle from instance
- delete: removed files created to build quardle
- add_config_file: create the config files associated to the quardle
- make_archive: create the quardle archive
Signed-off-by: leofvo <[email protected]>
- add_kernel: add kernel binary to quardle Signed-off-by: leofvo <[email protected]>
- setup: fetch all files needed to build inird image - add_init_rd: adding initramfs image to quardle Signed-off-by: leofvo <[email protected]>
Contributor
Author
|
Hey @sameo , my PR is ready for review ! |
leofvo
force-pushed
the
builder-leofvo
branch
5 times, most recently
from
999973f to
4fe07d4
Compare
- setup: install kaps sources - add_kaps: build kaps from sources and add it to quardle Signed-off-by: leofvo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.