Skip to content

Treat all sensor values and signed integers #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janvrany wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Treat all sensor values and signed integers #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions bricknil/sensor/peripheral.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,12 @@ def _convert_bytes(self, msg_bytes:bytearray, byte_count):
If multiple values, then a list of those values
Value can be either uint8, uint16, or uint32 depending on value of `byte_count`
"""
if byte_count == 1: # just a uint8
val = msg_bytes[0]
elif byte_count == 2: # uint16 little-endian
val = struct.unpack('<H', msg_bytes)[0]
elif byte_count == 4: # uint32 little-endian
val = struct.unpack('<I', msg_bytes)[0]
if byte_count == 1: # just an int8
val = struct.unpack('<b', msg_bytes)[0]
elif byte_count == 2: # int16 little-endian
val = struct.unpack('<h', msg_bytes)[0]
elif byte_count == 4: # int32 little-endian
val = struct.unpack('<i', msg_bytes)[0]
else:
self.message_error(f'Cannot convert array of {msg_bytes} length {len(msg_bytes)} to python datatype')
val = None
Expand Down