test(private-skills): guard batch sweep state ranking#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The batch-sweep ranker already rejects hydrated PRs with an unresolved REST merge state and correctly treats GitHub's year-1
completedAtvalue as unset for in-progress checks. Those review fixes landed in #21 without regression coverage, so either behavior could regress silently.Why This Change Was Made
Add focused CLI-level tests for both state-selection rules and wire the repository test target into
make ci. The fixtures cover an older completed failure and success followed by a newer in-progress run, ensuring both rejection and scoring behavior use the latest check.User Impact
Batch sweeps keep indeterminate merge states out of the final candidate list and do not rank PRs from stale check results.
Evidence
make testmake validatemake check-generatedpre-commit run --all-filesmake ci