Skip to content

Commit

Permalink
fix: websocket disconnection not handled properly
Browse files Browse the repository at this point in the history
  • Loading branch information
kennethnym committed Jul 28, 2024
1 parent 78ea024 commit 0179f03
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions server.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ async def ws_endpoint(ws: WebSocket):
await ws.close()
ws_connection_manager.disconnect(ws)

await ws.send_text(f"{len(active_listeners)}")
await ws_connection_manager.broadcast(f"{len(active_listeners)}")

try:
while True:
Expand All @@ -121,15 +121,12 @@ async def ws_endpoint(ws: WebSocket):
active_listeners.add(addr)
await ws_connection_manager.broadcast(f"{len(active_listeners)}")
elif msg == "paused":
active_listeners.remove(addr)
active_listeners.discard(addr)
await ws_connection_manager.broadcast(f"{len(active_listeners)}")

except WebSocketDisconnect:
if ws.client:
addr, _ = ws.client
active_listeners.discard(addr)
active_listeners.discard(addr)
ws_connection_manager.disconnect(ws)

await ws_connection_manager.broadcast(f"{len(active_listeners)}")


Expand Down

0 comments on commit 0179f03

Please sign in to comment.